Update to elastic-agent-client with chunking support. #37343

blakerouse · 2023-12-07T18:47:37Z

Proposed commit message

Update to elastic-agent-client with chunking support.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
~~[ ] I have made corresponding changes to the documentation~~
~~[ ] I have made corresponding change to the default configuration files~~
~~[ ] I have added tests that prove my fix is effective or that my feature works~~
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

Enables chunking support when communicating with the Elastic Agent.

How to test this PR locally

See elastic/elastic-agent#3884 for how to test.

Related issues

Relates Control protocol checkin payloads can exceed the gRPC maximum message size when using autodiscovery elastic-agent#2460

cla-checker-service · 2023-12-07T18:47:41Z

💚 CLA has been signed

mergify · 2023-12-07T18:48:17Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @blakerouse? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify · 2023-12-07T18:49:49Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b agent-client-chunking upstream/agent-client-chunking
git merge upstream/main
git push upstream agent-client-chunking

elasticmachine · 2023-12-07T18:54:38Z

💔 Build Failed

Expand to view the summary

Build stats

Duration: 7 min 32 sec

Pipeline error

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

blakerouse · 2023-12-07T18:56:41Z

go.mod replace will be removed once elastic/elastic-agent-client#89 is merged

elasticmachine · 2023-12-07T18:59:21Z

❕ Build Aborted

Expand to view the summary

Build stats

Duration: 6 min 42 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-12-07T21:03:08Z

💔 Build Failed

Expand to view the summary

Build stats

Start Time: 2023-12-07T18:54:26.168+0000
Duration: 128 min 26 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28676
Skipped	2015
Total	30691

Steps errors

Expand to view the steps failures

`x-pack/filebeat-goIntegTest - mage goIntegTest`

Took 7 min 35 sec . View more details here
Description: mage goIntegTest

`x-pack/libbeat-unitTest - mage build unitTest`

Took 4 min 18 sec . View more details here
Description: mage build unitTest

`x-pack/libbeat-unitTest - mage build unitTest`

Took 1 min 34 sec . View more details here
Description: mage build unitTest

`x-pack/libbeat-unitTest - mage build unitTest`

Took 1 min 35 sec . View more details here
Description: mage build unitTest

`x-pack/libbeat-goIntegTest - mage goIntegTest`

Took 5 min 6 sec . View more details here
Description: mage goIntegTest

`x-pack/libbeat-goIntegTest - mage goIntegTest`

Took 1 min 11 sec . View more details here
Description: mage goIntegTest

`x-pack/libbeat-goIntegTest - mage goIntegTest`

Took 1 min 12 sec . View more details here
Description: mage goIntegTest

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'hudson.AbortException: script returned exit code 1'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-12-08T18:53:26Z

💔 Build Failed

Expand to view the summary

Build stats

Duration: 129 min 45 sec

Pipeline error

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

blakerouse · 2023-12-18T16:12:11Z

go.mod replace has been removed, now that v7.6.0 of elastic-agent-client has been released

elasticmachine · 2023-12-18T16:52:52Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-12-18T16:11:58.452+0000
Duration: 41 min 44 sec

Test stats 🧪

Test	Results
Failed	0
Passed	8948
Skipped	593
Total	9541

Steps errors

Expand to view the steps failures

`x-pack/libbeat-unitTest - mage build unitTest`

Took 4 min 25 sec . View more details here
Description: mage build unitTest

`x-pack/libbeat-unitTest - mage build unitTest`

Took 1 min 35 sec . View more details here
Description: mage build unitTest

`x-pack/libbeat-unitTest - mage build unitTest`

Took 1 min 35 sec . View more details here
Description: mage build unitTest

`x-pack/libbeat-goIntegTest - mage goIntegTest`

Took 5 min 14 sec . View more details here
Description: mage goIntegTest

`x-pack/libbeat-goIntegTest - mage goIntegTest`

Took 1 min 15 sec . View more details here
Description: mage goIntegTest

`x-pack/libbeat-goIntegTest - mage goIntegTest`

Took 1 min 14 sec . View more details here
Description: mage goIntegTest

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'org.jenkinsci.plugins.workflow.steps.FlowInterruptedException'

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-12-18T16:56:22Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-12-18T16:23:54.066+0000
Duration: 32 min 14 sec

Test stats 🧪

Test	Results
Failed	7
Passed	4663
Skipped	38
Total	4708

Test errors

Expand to view the tests failures

`Build&Test / libbeat-unitTest / [empty] – TEST-go-unit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-37343-8-6448dda7-98bd-4ede-a5e7-f9967892ade6/src/github.com/elastic/beats/build/libbeat/build/TEST-go-unit.xml was length 0

`Build&Test / x-pack/libbeat-unitTest / [empty] – TEST-go-unit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-37343-8-fb8c5b14-0536-4e6a-bf10-e9488bc43fb8/src/github.com/elastic/beats/build/x-pack/libbeat/build/TEST-go-unit.xml was length 0

`Build&Test / metricbeat-unitTest / TestAll – github.com/elastic/beats/v7/metricbeat/mb/testing/data`

Expand to view the error details

 Failed

Expand to view the stacktrace

 === RUN   TestAll
=== RUN   TestAll/apache.status
--- PASS: TestAll/apache.status (0.75s)
=== RUN   TestAll/apache.status/docs.plain
    testdata.go:238: Testing ../../../module/apache/status/_meta/testdata/docs.plain file
    testdata.go:307: Expected ../../../module/apache/status/_meta/testdata/docs.plain-expected.json file
--- PASS: TestAll/apache.status/docs.plain (0.75s)
=== RUN   TestAll/ceph.mgr_cluster_disk
--- PASS: TestAll/ceph.mgr_cluster_disk (1.43s)
=== RUN   TestAll/ceph.mgr_cluster_disk/failed.json
    testdata.go:238: Testing ../../../module/ceph/mgr_cluster_disk/_meta/testdata/failed.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_cluster_disk/_meta/testdata/failed.json-expected.json file
--- PASS: TestAll/ceph.mgr_cluster_disk/failed.json (0.81s)
=== RUN   TestAll/ceph.mgr_cluster_disk/sample.json
    testdata.go:238: Testing ../../../module/ceph/mgr_cluster_disk/_meta/testdata/sample.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_cluster_disk/_meta/testdata/sample.json-expected.json file
--- PASS: TestAll/ceph.mgr_cluster_disk/sample.json (0.62s)
=== RUN   TestAll/ceph.mgr_osd_perf
--- PASS: TestAll/ceph.mgr_osd_perf (1.53s)
=== RUN   TestAll/ceph.mgr_osd_perf/failed.json
    testdata.go:238: Testing ../../../module/ceph/mgr_osd_perf/_meta/testdata/failed.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_osd_perf/_meta/testdata/failed.json-expected.json file
--- PASS: TestAll/ceph.mgr_osd_perf/failed.json (0.70s)
=== RUN   TestAll/ceph.mgr_osd_perf/sample.json
    testdata.go:238: Testing ../../../module/ceph/mgr_osd_perf/_meta/testdata/sample.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_osd_perf/_meta/testdata/sample.json-expected.json file
--- PASS: TestAll/ceph.mgr_osd_perf/sample.json (0.83s)
=== RUN   TestAll/ceph.mgr_osd_pool_stats
--- PASS: TestAll/ceph.mgr_osd_pool_stats (1.47s)
=== RUN   TestAll/ceph.mgr_osd_pool_stats/failed.json
    testdata.go:238: Testing ../../../module/ceph/mgr_osd_pool_stats/_meta/testdata/failed.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_osd_pool_stats/_meta/testdata/failed.json-expected.json file
--- PASS: TestAll/ceph.mgr_osd_pool_stats/failed.json (0.75s)
=== RUN   TestAll/ceph.mgr_osd_pool_stats/sample.json
    testdata.go:238: Testing ../../../module/ceph/mgr_osd_pool_stats/_meta/testdata/sample.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_osd_pool_stats/_meta/testdata/sample.json-expected.json file
--- PASS: TestAll/ceph.mgr_osd_pool_stats/sample.json (0.72s)
=== RUN   TestAll/ceph.mgr_osd_tree
--- PASS: TestAll/ceph.mgr_osd_tree (1.32s)
=== RUN   TestAll/ceph.mgr_osd_tree/failed.json
    testdata.go:238: Testing ../../../module/ceph/mgr_osd_tree/_meta/testdata/failed.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_osd_tree/_meta/testdata/failed.json-expected.json file
--- PASS: TestAll/ceph.mgr_osd_tree/failed.json (0.78s)
=== RUN   TestAll/ceph.mgr_osd_tree/sample.json
    testdata.go:238: Testing ../../../module/ceph/mgr_osd_tree/_meta/testdata/sample.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_osd_tree/_meta/testdata/sample.json-expected.json file
--- PASS: TestAll/ceph.mgr_osd_tree/sample.json (0.54s)
=== RUN   TestAll/ceph.mgr_pool_disk
--- PASS: TestAll/ceph.mgr_pool_disk (1.29s)
=== RUN   TestAll/ceph.mgr_pool_disk/failed.json
    testdata.go:238: Testing ../../../module/ceph/mgr_pool_disk/_meta/testdata/failed.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_pool_disk/_meta/testdata/failed.json-expected.json file
--- PASS: TestAll/ceph.mgr_pool_disk/failed.json (0.65s)
=== RUN   TestAll/ceph.mgr_pool_disk/sample.json
    testdata.go:238: Testing ../../../module/ceph/mgr_pool_disk/_meta/testdata/sample.json file
    testdata.go:307: Expected ../../../module/ceph/mgr_pool_disk/_meta/testdata/sample.json-expected.json file
--- PASS: TestAll/ceph.mgr_pool_disk/sample.json (0.64s)
=== RUN   TestAll/ceph.monitor_health
--- PASS: TestAll/ceph.monitor_health (0.52s)
=== RUN   TestAll/ceph.monitor_health/docs.json
    testdata.go:238: Testing ../../../module/ceph/monitor_health/_meta/testdata/docs.json file
    testdata.go:307: Expected ../../../module/ceph/monitor_health/_meta/testdata/docs.json-expected.json file
--- PASS: TestAll/ceph.monitor_health/docs.json (0.52s)
=== RUN   TestAll/couchbase.cluster
--- PASS: TestAll/couchbase.cluster (1.40s)
=== RUN   TestAll/couchbase.cluster/4.5.1.json
    testdata.go:238: Testing ../../../module/couchbase/cluster/_meta/testdata/4.5.1.json file
    testdata.go:307: Expected ../../../module/couchbase/cluster/_meta/testdata/4.5.1.json-expected.json file
--- PASS: TestAll/couchbase.cluster/4.5.1.json (0.74s)
=== RUN   TestAll/couchbase.cluster/docs.json
    testdata.go:238: Testing ../../../module/couchbase/cluster/_meta/testdata/docs.json file
    testdata.go:307: Expected ../../../module/couchbase/cluster/_meta/testdata/docs.json-expected.json file
--- PASS: TestAll/couchbase.cluster/docs.json (0.66s)
=== RUN   TestAll/couchbase.node
--- PASS: TestAll/couchbase.node (1.24s)
=== RUN   TestAll/couchbase.node/4.5.1.json
    testdata.go:238: Testing ../../../module/couchbase/node/_meta/testdata/4.5.1.json file
    testdata.go:307: Expected ../../../module/couchbase/node/_meta/testdata/4.5.1.json-expected.json file
--- PASS: TestAll/couchbase.node/4.5.1.json (0.68s)
=== RUN   TestAll/couchbase.node/docs.json
    testdata.go:238: Testing ../../../module/couchbase/node/_meta/testdata/docs.json file
    testdata.go:307: Expected ../../../module/couchbase/node/_meta/testdata/docs.json-expected.json file
--- PASS: TestAll/couchbase.node/docs.json (0.57s)
=== RUN   TestAll/dropwizard.collector
--- PASS: TestAll/dropwizard.collector (0.50s)
=== RUN   TestAll/dropwizard.collector/docs.json
    testdata.go:238: Testing ../../../module/dropwizard/collector/_meta/testdata/docs.json file
    testdata.go:307: Expected ../../../module/dropwizard/collector/_meta/testdata/docs.json-expected.json file
--- PASS: TestAll/dropwizard.collector/docs.json (0.50s)
=== RUN   TestAll/etcd.metrics
--- PASS: TestAll/etcd.metrics (0.48s)
=== RUN   TestAll/etcd.metrics/metrics.plain
    testdata.go:238: Testing ../../../module/etcd/metrics/_meta/testdata/metrics.plain file
    testdata.go:307: Expected ../../../module/etcd/metrics/_meta/testdata/metrics.plain-expected.json file
--- PASS: TestAll/etcd.metrics/metrics.plain (0.48s)
=== RUN   TestAll/http.json
--- PASS: TestAll/http.json (0.67s)
=== RUN   TestAll/http.json/docs.json
    testdata.go:238: Testing ../../../module/http/json/_meta/testdata/docs.json file
    testdata.go:307: Expected ../../../module/http/json/_meta/testdata/docs.json-expected.json file
--- PASS: TestAll/http.json/docs.json (0.67s)
=== RUN   TestAll/kibana.status
--- PASS: TestAll/kibana.status (1.51s)
=== RUN   TestAll/kibana.status/7.0.0.json
    testdata.go:238: Testing ../../../module/kibana/status/_meta/testdata/7.0.0.json file
    testdata.go:307: Expected ../../../module/kibana/status/_meta/testdata/7.0.0.json-expected.json file
--- PASS: TestAll/kibana.status/7.0.0.json (0.79s)
=== RUN   TestAll/kibana.status/docs.json
    testdata.go:238: Testing ../../../module/kibana/status/_meta/testdata/docs.json file
    testdata.go:307: Expected ../../../module/kibana/status/_meta/testdata/docs.json-expected.json file
--- PASS: TestAll/kibana.status/docs.json (0.71s)
=== RUN   TestAll/kubernetes.apiserver
--- PASS: TestAll/kubernetes.apiserver (1.97s)
=== RUN   TestAll/kubernetes.apiserver/docs.plain
    testdata.go:238: Testing ../../../module/kubernetes/apiserver/_meta/testdata/docs.plain file
    testdata.go:307: Expected ../../../module/kubernetes/apiserver/_meta/testdata/docs.plain-expected.json file
--- PASS: TestAll/kubernetes.apiserver/docs.plain (1.97s)
=== RUN   TestAll/kubernetes.controllermanager
--- PASS: TestAll/kubernetes.controllermanager (1.05s)
=== RUN   TestAll/kubernetes.controllermanager/docs.plain
    testdata.go:238: Testing ../../../module/kubernetes/controllermanager/_meta/testdata/docs.plain file
    testdata.go:307: Expected ../../../module/kubernetes/controllermanager/_meta/testdata/docs.plain-expected.json file
--- PASS: TestAll/kubernetes.controllermanager/docs.plain (1.05s)
=== RUN   TestAll/kubernetes.proxy
--- PASS: TestAll/kubernetes.proxy (0.76s)
=== RUN   TestAll/kubernetes.proxy/docs.plain
    testdata.go:238: Testing ../../../module/kubernetes/proxy/_meta/testdata/docs.plain file
    testdata.go:307: Expected ../../../module/kubernetes/proxy/_meta/testdata/docs.plain-expected.json file
--- PASS: TestAll/kubernetes.proxy/docs.plain (0.76s)
=== RUN   TestAll/kubernetes.scheduler
--- PASS: TestAll/kubernetes.scheduler (0.73s)
=== RUN   TestAll/kubernetes.scheduler/docs.plain
    testdata.go:238: Testing ../../../module/kubernetes/scheduler/_meta/testdata/docs.plain file
    testdata.go:307: Expected ../../../module/kubernetes/scheduler/_meta/testdata/docs.plain-expected.json file
--- PASS: TestAll/kubernetes.scheduler/docs.plain (0.73s)
=== RUN   TestAll/kubernetes.state_container
--- PASS: TestAll/kubernetes.state_container (2.49s)
=== RUN   TestAll/kubernetes.state_container/docs.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/docs.plain file
    testdata.go:307: Expected ../../../module/kubernetes/state_container/_meta/testdata/docs.plain-expected.json file
--- PASS: TestAll/kubernetes.state_container/docs.plain (0.75s)
=== RUN   TestAll/kubernetes.state_container/ksm.v2.10.0.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/ksm.v2.10.0.plain file
    testdata.go:307: Expected ../../../module/kubernetes/state_container/_meta/testdata/ksm.v2.10.0.plain-expected.json file
--- PASS: TestAll/kubernetes.state_container/ksm.v2.10.0.plain (0.60s)
=== RUN   TestAll/kubernetes.state_container/ksm.v2.8.2.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/ksm.v2.8.2.plain file
    testdata.go:307: Expected ../../../module/kubernetes/state_container/_meta/testdata/ksm.v2.8.2.plain-expected.json file
--- PASS: TestAll/kubernetes.state_container/ksm.v2.8.2.plain (0.58s)
=== RUN   TestAll/kubernetes.state_container/ksm.v2.9.2.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/ksm.v2.9.2.plain file
    testdata.go:307: Expected ../../../module/kubernetes/state_container/_meta/testdata/ksm.v2.9.2.plain-expected.json file
--- PASS: TestAll/kubernetes.state_container/ksm.v2.9.2.plain (0.56s)
=== RUN   TestAll/kubernetes.state_cronjob
=== RUN   TestAll/kubernetes.state_cronjob/docs.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/docs.plain file
    testdata.go:307: Expected ../../../module/kubernetes/state_cronjob/_meta/testdata/docs.plain-expected.json file
--- PASS: TestAll/kubernetes.state_cronjob/docs.plain (0.47s)
=== RUN   TestAll/kubernetes.state_cronjob/ksm.v2.10.0.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/ksm.v2.10.0.plain file
    testdata.go:307: Expected ../../../module/kubernetes/state_cronjob/_meta/testdata/ksm.v2.10.0.plain-expected.json file
--- PASS: TestAll/kubernetes.state_cronjob/ksm.v2.10.0.plain (0.49s)
=== RUN   TestAll/kubernetes.state_cronjob/ksm.v2.8.2.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/ksm.v2.8.2.plain file

`Build&Test / metricbeat-unitTest / TestAll/kubernetes.state_cronjob – github.com/elastic/beats/v7/metricbeat/mb/testing/data`

Expand to view the error details

 Failed

Expand to view the stacktrace

 === RUN   TestAll/kubernetes.state_cronjob

`Build&Test / metricbeat-unitTest / TestAll/kubernetes.state_cronjob/ksm.v2.8.2.plain – github.com/elastic/beats/v7/metricbeat/mb/testing/data`

Expand to view the error details

 Failed

Expand to view the stacktrace

 === RUN   TestAll/kubernetes.state_cronjob/ksm.v2.8.2.plain
    testdata.go:238: Testing ../../../module/kubernetes/_meta/test/KSM/ksm.v2.8.2.plain file

`Build&Test / x-pack/filebeat-goIntegTest / [empty] – TEST-go-integration.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-37343-8-db675eb2-d8d3-483a-96de-e7359bd8dbd5/src/github.com/elastic/beats/build/x-pack/filebeat/build/TEST-go-integration.xml was length 0

`Build&Test / x-pack/functionbeat-unitTest / [empty] – TEST-go-unit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-37343-8-73fab0a6-2dce-4287-92ee-f8d676982d20/src/github.com/elastic/beats/build/x-pack/functionbeat/build/TEST-go-unit.xml was length 0

Steps errors

Expand to view the steps failures

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'org.jenkinsci.plugins.workflow.steps.FlowInterruptedException'

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-12-18T19:30:04Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 163 min 10 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cmacknz · 2023-12-18T19:39:25Z

x-pack/libbeat/management/simple_input_config_test.go

@@ -133,7 +133,7 @@ func TestSimpleInputConfig(t *testing.T) {
 		fmt.Sprintf(":%d", server.Port),
 		"",
 		client.VersionInfo{},
-		grpc.WithTransportCredentials(insecure.NewCredentials()))
+		client.WithGRPCDialOptions(grpc.WithTransportCredentials(insecure.NewCredentials())))


Can the test in here be modified to verify that chunking works as expected?

Doesn't make sense to test a feature of an external library. The library handles all the chunking and ensures that its on, and that library is fully tested.

In this case where there are essentially no changes besides the dependency this seems reasonable.

I am a bit worried that nothing is actually testing that this works with a real Beat anywhere though. If we can force an existing integration test in the agent repository to use chunking for everything that's probably a better way to test this.

elasticmachine · 2023-12-18T22:13:28Z

💚 Build Succeeded

Expand to view the summary

Build stats

Start Time: 2023-12-18T19:29:21.744+0000
Duration: 164 min 51 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28732
Skipped	2015
Total	30747

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

* Update to elastic-agent-client with chunking support. * Add changelog entry. * Fix changelog again. * Update to v7.6.0 elastic-agent-client. * Fix tests. * Fix another test. * Fix windows lint.

blakerouse added the Team:Elastic-Agent Label for the Agent team label Dec 7, 2023

blakerouse self-assigned this Dec 7, 2023

blakerouse requested review from a team as code owners December 7, 2023 18:47

blakerouse requested review from ycombinator and belimawr December 7, 2023 18:47

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 7, 2023

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 7, 2023

blakerouse added 2 commits December 7, 2023 13:50

Update to elastic-agent-client with chunking support.

18e51c3

Add changelog entry.

a276c93

blakerouse force-pushed the agent-client-chunking branch from 64a2051 to a276c93 Compare December 7, 2023 18:51

blakerouse added the backport-skip Skip notification from the automated backport with mergify label Dec 7, 2023

blakerouse added 2 commits December 7, 2023 13:52

Merge remote-tracking branch 'upstream/main' into agent-client-chunking

75e67ea

Fix changelog again.

a00215c

rdner mentioned this pull request Dec 7, 2023

Add filestream benchmarks for many files case, fix data race #37345

Merged

3 tasks

blakerouse added 2 commits December 18, 2023 11:05

Merge branch 'main' into agent-client-chunking

789bbd4

Update to v7.6.0 elastic-agent-client.

e82a2e5

blakerouse force-pushed the agent-client-chunking branch from 0fdf2ae to e82a2e5 Compare December 18, 2023 16:11

blakerouse added 2 commits December 18, 2023 11:23

Fix tests.

e88f7ab

Fix another test.

f63c67d

Fix windows lint.

8102e54

cmacknz reviewed Dec 18, 2023

View reviewed changes

cmacknz approved these changes Dec 18, 2023

View reviewed changes

blakerouse enabled auto-merge (squash) December 18, 2023 20:00

blakerouse merged commit 5fab3e9 into elastic:main Dec 18, 2023
119 checks passed

blakerouse deleted the agent-client-chunking branch December 19, 2023 14:33

Update to elastic-agent-client with chunking support. #37343

Update to elastic-agent-client with chunking support. #37343

Conversation

blakerouse commented Dec 7, 2023 • edited Loading

Proposed commit message

Checklist

Author's Checklist

How to test this PR locally

Related issues

cla-checker-service bot commented Dec 7, 2023 • edited Loading

mergify bot commented Dec 7, 2023

mergify bot commented Dec 7, 2023

elasticmachine commented Dec 7, 2023

💔 Build Failed

Build stats

Pipeline error

❕ Flaky test report

🤖 GitHub comments

blakerouse commented Dec 7, 2023

elasticmachine commented Dec 7, 2023

❕ Build Aborted

Build stats

🤖 GitHub comments

elasticmachine commented Dec 7, 2023

💔 Build Failed

Build stats

Test stats 🧪

Steps errors

x-pack/filebeat-goIntegTest - mage goIntegTest

x-pack/libbeat-unitTest - mage build unitTest

x-pack/libbeat-unitTest - mage build unitTest

x-pack/libbeat-unitTest - mage build unitTest

x-pack/libbeat-goIntegTest - mage goIntegTest

x-pack/libbeat-goIntegTest - mage goIntegTest

x-pack/libbeat-goIntegTest - mage goIntegTest

Error signal

💚 Flaky test report

🤖 GitHub comments

elasticmachine commented Dec 8, 2023

💔 Build Failed

Build stats

Pipeline error

❕ Flaky test report

🤖 GitHub comments

blakerouse commented Dec 18, 2023

elasticmachine commented Dec 18, 2023

❕ Build Aborted

Build stats

Test stats 🧪

Steps errors

x-pack/libbeat-unitTest - mage build unitTest

x-pack/libbeat-unitTest - mage build unitTest

x-pack/libbeat-unitTest - mage build unitTest

x-pack/libbeat-goIntegTest - mage goIntegTest

x-pack/libbeat-goIntegTest - mage goIntegTest

x-pack/libbeat-goIntegTest - mage goIntegTest

Error signal

🤖 GitHub comments

elasticmachine commented Dec 18, 2023

❕ Build Aborted

Build stats

Test stats 🧪

Test errors

Build&Test / libbeat-unitTest / [empty] – TEST-go-unit.xml

Build&Test / x-pack/libbeat-unitTest / [empty] – TEST-go-unit.xml

Build&Test / metricbeat-unitTest / TestAll – github.com/elastic/beats/v7/metricbeat/mb/testing/data

Build&Test / metricbeat-unitTest / TestAll/kubernetes.state_cronjob – github.com/elastic/beats/v7/metricbeat/mb/testing/data

Build&Test / metricbeat-unitTest / TestAll/kubernetes.state_cronjob/ksm.v2.8.2.plain – github.com/elastic/beats/v7/metricbeat/mb/testing/data

Build&Test / x-pack/filebeat-goIntegTest / [empty] – TEST-go-integration.xml

Build&Test / x-pack/functionbeat-unitTest / [empty] – TEST-go-unit.xml

Steps errors

Error signal

🤖 GitHub comments

elasticmachine commented Dec 18, 2023

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

cmacknz Dec 18, 2023

Choose a reason for hiding this comment

blakerouse commented Dec 7, 2023 •

edited

Loading

cla-checker-service bot commented Dec 7, 2023 •

edited

Loading

`x-pack/filebeat-goIntegTest - mage goIntegTest`

`x-pack/libbeat-unitTest - mage build unitTest`

`x-pack/libbeat-unitTest - mage build unitTest`

`x-pack/libbeat-unitTest - mage build unitTest`

`x-pack/libbeat-goIntegTest - mage goIntegTest`

`x-pack/libbeat-goIntegTest - mage goIntegTest`

`x-pack/libbeat-goIntegTest - mage goIntegTest`

`Error signal`

`x-pack/libbeat-unitTest - mage build unitTest`

`x-pack/libbeat-unitTest - mage build unitTest`

`x-pack/libbeat-unitTest - mage build unitTest`

`x-pack/libbeat-goIntegTest - mage goIntegTest`

`x-pack/libbeat-goIntegTest - mage goIntegTest`

`x-pack/libbeat-goIntegTest - mage goIntegTest`

`Error signal`

`Build&Test / libbeat-unitTest / [empty] – TEST-go-unit.xml`

`Build&Test / x-pack/libbeat-unitTest / [empty] – TEST-go-unit.xml`

`Build&Test / metricbeat-unitTest / TestAll – github.com/elastic/beats/v7/metricbeat/mb/testing/data`

`Build&Test / metricbeat-unitTest / TestAll/kubernetes.state_cronjob – github.com/elastic/beats/v7/metricbeat/mb/testing/data`

`Build&Test / metricbeat-unitTest / TestAll/kubernetes.state_cronjob/ksm.v2.8.2.plain – github.com/elastic/beats/v7/metricbeat/mb/testing/data`

`Build&Test / x-pack/filebeat-goIntegTest / [empty] – TEST-go-integration.xml`

`Build&Test / x-pack/functionbeat-unitTest / [empty] – TEST-go-unit.xml`

`Error signal`